Tide support #280
Merged
Tide support #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces support for Tide by implementing `From` over markup. Unlike other frameworks, Tide does not seem to provide e.g. a trait which could instead be implemented. However as demonstrated, this alternative results in a simple, ergonomic interface. Consumers may leverage Tide support by using the "tide" feature.
|
Thanks for looking at this, @lambda-fairy--I think the doctest build should be passing now. |
lambda-fairy
requested changes
Aug 4, 2021
There was a problem hiding this comment.
Thanks @maxcountryman!
Can you please add an entry to the changelog as well?
Other than the minor nits, LGTM.
| mod tide_support { | ||
| use crate::PreEscaped; | ||
| use alloc::{format, string::String}; | ||
| use tide::{http::mime, Response, StatusCode}; |
There was a problem hiding this comment.
No action needed here, but it would be nice to standardize on an import style at some point.
Filed #281 for this.
doctest/Cargo.toml
Outdated
| @@ -7,11 +7,13 @@ edition = "2018" | |||
| [dependencies] | |||
| actix-web = "3" | |||
| ammonia = "3" | |||
| async-std = {version = "1.9.0", features = ["attributes"]} | |||
There was a problem hiding this comment.
nit: add spaces
Suggested change
| async-std = {version = "1.9.0", features = ["attributes"]} | |
| async-std = { version = "1.9.0", features = ["attributes"] } |
There was a problem hiding this comment.
I've instead broken this out; there's a consideration for consistency, but I'll leave that up to you to decide if that's something you want to apply more generally.
maxcountryman
force-pushed
the
feature/tide
branch
from
a90aa24
to
1a81fea
Compare
maxcountryman
force-pushed
the
feature/tide
branch
from
1a81fea
to
cffd9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for Tide by implementing
Fromover markup.Unlike other frameworks, Tide does not seem to provide e.g. a trait
which could instead be implemented. However as demonstrated, this
alternative results in a simple, ergonomic interface.
Consumers may leverage Tide support by using the "tide" feature.