Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strerror_r error test #88

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Nov 14, 2023

Fixes #45.

man 3 strerror_r says:

The XSI-compliant strerror_r() function returns 0 on success. On error, a (positive) error number is returned (since glibc 2.13), or -1 is returned and errno is set to indicate the error (glibc versions before 2.13).

@Ralith Ralith force-pushed the fix-strerror-error branch 2 times, most recently from 5c0c3ea to b48f0cd Compare November 14, 2023 20:37
Copy link
Collaborator

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/wasi.rs Outdated Show resolved Hide resolved
src/unix.rs Show resolved Hide resolved
`man 3 strerror_r` says:

The XSI-compliant strerror_r() function returns 0 on success. On
error, a (positive) error number is returned (since glibc 2.13), or -1
is returned and errno is set to indicate the error (glibc versions
before 2.13).
@Ralith Ralith force-pushed the fix-strerror-error branch from b48f0cd to 1876877 Compare November 14, 2023 22:14
Copy link
Collaborator

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunfishcode sunfishcode merged commit 0420960 into lambda-fairy:main Nov 15, 2023
11 checks passed
@sunfishcode
Copy link
Collaborator

This is now released in 0.3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strerror_r check is incorrect
2 participants