Skip to content

Commit

Permalink
Add changelog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
fmoletta committed Jan 25, 2023
1 parent 8d23b82 commit b964ff2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

#### Upcoming Changes

* Add `VmException` to `CairoRunner::run_from_entrypoint`[#775](https://github.com/lambdaclass/cairo-rs/pull/775)
* Public Api Changes:
* Change error return type of `CairoRunner::run_from_entrypoint` to `CairoRunError`.
* Convert `VirtualMachineError`s outputed during the vm run to `VmException` in `CairoRunner::run_from_entrypoint`.

* Use CairoArg enum instead of Any in CairoRunner::run_from_entrypoint [#686](https://github.com/lambdaclass/cairo-rs/pull/686)
* Public Api changes:
* Remove `Result` from `MaybeRelocatable::mod_floor`, it now returns a `MaybeRelocatable`
Expand Down

1 comment on commit b964ff2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: b964ff2 Previous: 6807886 Ratio
cairo_run(cairo_programs/benchmarks/linear_search.json 113584167 ns/iter (± 3940924) 86492486 ns/iter (± 1414095) 1.31
cairo_run(cairo_programs/benchmarks/secp_integration_benchmark.json 1968307246 ns/iter (± 56549406) 1406273719 ns/iter (± 14615489) 1.40
cairo_run(cairo_programs/benchmarks/math_cmp_and_pow_integration_benchmark.json 24136731 ns/iter (± 921413) 18316009 ns/iter (± 227718) 1.32
cairo_run(cairo_programs/benchmarks/uint256_integration_benchmark.json 1564356273 ns/iter (± 60334767) 1175085616 ns/iter (± 17705744) 1.33

This comment was automatically generated by workflow using github-action-benchmark.

CC: @unbalancedparentheses

Please sign in to comment.