Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property based testing for felt operations #700

Closed
21 tasks done
martinacantaro opened this issue Jan 9, 2023 · 3 comments · Fixed by #822
Closed
21 tasks done

Add property based testing for felt operations #700

martinacantaro opened this issue Jan 9, 2023 · 3 comments · Fixed by #822
Labels
enhancement New feature or request

Comments

@martinacantaro
Copy link
Contributor

martinacantaro commented Jan 9, 2023 •
edited
Loading

Add property based testing using proptest to ensure operations done with felts are working correctly. These are all the current operations available for felts. Those marked as done have been tested using proptest.

  • Add
  • AddAssign
  • BitAnd
    • BitAnd Zeros
  • BitOr
    • BitOr Zeros
  • BitXor
    • BitXor Zeros
  • Div
  • Mul
    • Mul Zeros
  • MulAssign
  • Neg
  • Rem
  • Shl
  • Shr
  • ShrAssign
  • Sub
  • SubAssign
  • Sum
    • Sum Zeros
@martinacantaro martinacantaro added the enhancement New feature or request label Jan 9, 2023
This was referenced Jan 9, 2023
Merged
Merged
Merged
@martinacantaro martinacantaro changed the title Add property based testing Add property based testing for felt operations Jan 13, 2023
@martinacantaro
Copy link
Contributor Author

Something to improve: due to the way we wrote the regexes, zeroes are overrepresented.

This was referenced Jan 13, 2023
Merged
Merged
Closed
Merged
Merged
Merged
@martinacantaro martinacantaro mentioned this issue Feb 2, 2023
Merged
4 tasks
@martinacantaro
Copy link
Contributor Author

I need to fix the iter::sum test, since it tests simple addition and not iterative sum

@martinacantaro
Copy link
Contributor Author

Sum Zeros is actually testing Add Zeros, fix this

@martinacantaro martinacantaro mentioned this issue Feb 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Felt proptests lambdaclass/cairo-vm
1 participant
@martinacantaro