Add property testing for Felt bit shifts #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinacantaro
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
HermanObst,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
martinacantaro
changed the title
|
Tests look good! but one thing I see consistently missing is comments on tests indicating motivation, what the tests wants to check, and not how it does it. This improves both understanding for newcomers, modification of the tests in the future, and most importantly, debugging when someone else makes them fail. |
|
Agree! Will make the required changes |
|
Added comments to each test. Please don't merge because I also want to check if a particular change to the tests is needed |
added 2 commits
January 10, 2023 13:03
|
All done! The change wasn't necessary |
martinacantaro
changed the title
martinacantaro
changed the title
Oppen
approved these changes
Jan 12, 2023
added 2 commits
January 12, 2023 18:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add property testing for Felt bit shifts
Description
Property-based test that ensures, for 100
values that are randomly generated each time tests are run, that performing a bit shift to the left or to the right byshift_amountof bits (between 0 and 999) returns a result that is inside of the range [0, p].Checklist