-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Hint#48 pack512 #1000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1000! 🎉 🎉 🎉 |
Oppen
reviewed
Apr 18, 2023
Oppen
reviewed
Apr 19, 2023
Benchmark Results for unmodified programs 🚀
|
pefontana
requested review from
igaray,
fmoletta,
entropidelic,
juanbono and
Juan-M-V
as code owners
April 20, 2023 19:47
pefontana
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 20, 2023
Oppen
approved these changes
Apr 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1000 +/- ##
========================================
Coverage 98.07% 98.08%
========================================
Files 78 79 +1
Lines 32541 32663 +122
========================================
+ Hits 31916 32038 +122
Misses 625 625
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MegaRedHand
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/hint_processor/builtin_hint_processor/vrf/inv_mod_p_uint512.rs
Outdated
Show resolved
Hide resolved
Closed
Oppen
approved these changes
Apr 21, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add cairo program for integration test * WIP implement hint * Add pack_512 fn + unit tests * Update pack_512.cairo * Add hint code && implement hint * Reimplement pack_512 function && fix hint * handle error * Fix merge conflicts * Update Changelog * Rename pack_512.rs -> inv_mod_p_uint512.rs * Add integration test * Rename u255.cairo -> cairo_programs/fq_uint256.cairo * pack_512 -> BigUint * Add unit test * fix wasm tests * Remove fq_uint256.cairo * use u128::MAX * fix tests --------- Co-authored-by: Pedro Fontana <pedro.fontana@lamdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Hint#48 pack512
Description
issue: #979
Implement hint:
Checklist