Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: script to keep track of missing hints #1015

Merged
merged 1 commit into from
Apr 21, 2023
Merged

ci: script to keep track of missing hints #1015

merged 1 commit into from
Apr 21, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Apr 19, 2023

Adds a little application that tries to run every hint in the included whitelists and checks if UnknownHint is reported, then reports the missing hints to issue #1031

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 3.547 ± 0.074 3.488 3.703 1.01 ± 0.03
head blake2s_integration_benchmark 3.525 ± 0.066 3.452 3.682 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.261 ± 0.092 4.123 4.365 1.01 ± 0.03
head compare_arrays_200000 4.202 ± 0.075 4.110 4.349 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.169 ± 0.082 3.091 3.337 1.00 ± 0.03
head dict_integration_benchmark 3.155 ± 0.038 3.105 3.230 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.147 ± 0.085 5.069 5.343 1.00
head factorial_multirun 5.202 ± 0.114 5.067 5.412 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.158 ± 0.043 4.097 4.222 1.01 ± 0.02
head fibonacci_1000_multirun 4.115 ± 0.085 4.036 4.325 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 138.8 ± 3.0 135.3 145.0 1.00
head field_arithmetic_get_square_benchmark 139.8 ± 1.7 138.3 142.6 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 4.112 ± 0.032 4.052 4.172 1.00
head integration_builtins 4.169 ± 0.102 4.075 4.435 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 3.828 ± 0.048 3.762 3.908 1.00
head keccak_integration_benchmark 3.898 ± 0.075 3.813 4.086 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.329 ± 0.063 4.247 4.426 1.01 ± 0.02
head linear_search 4.287 ± 0.053 4.212 4.359 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.555 ± 0.055 3.486 3.648 1.00 ± 0.03
head math_cmp_and_pow_integration_benchmark 3.542 ± 0.071 3.476 3.661 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.179 ± 0.031 3.113 3.213 1.00
head math_integration_benchmark 3.205 ± 0.038 3.163 3.268 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.849 ± 0.039 2.802 2.944 1.00
head memory_integration_benchmark 2.852 ± 0.039 2.803 2.915 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.784 ± 0.040 2.725 2.846 1.05 ± 0.07
head operations_with_data_structures_benchmarks 2.656 ± 0.166 2.470 2.976 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 4.115 ± 0.090 3.885 4.216 1.08 ± 0.03
head pedersen 3.802 ± 0.054 3.724 3.886 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.570 ± 0.027 1.538 1.630 1.00
head poseidon_integration_benchmark 1.611 ± 0.049 1.549 1.714 1.03 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.972 ± 0.056 2.910 3.086 1.00
head secp_integration_benchmark 3.017 ± 0.088 2.953 3.198 1.02 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.184 ± 0.032 2.134 2.226 1.00
head set_integration_benchmark 2.255 ± 0.124 2.156 2.505 1.03 ± 0.06
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.431 ± 0.126 4.186 4.585 1.00
head uint256_integration_benchmark 4.517 ± 0.242 4.207 4.871 1.02 ± 0.06

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1015 (cb5bef7) into main (e116860) will not change coverage.
The diff coverage is n/a.

❗ Current head cb5bef7 differs from pull request most recent head 09b890e. Consider uploading reports for the commit 09b890e to get more accurate results

@@           Coverage Diff           @@
##             main    #1015   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          78       78           
  Lines       32572    32572           
=======================================
  Hits        31947    31947           
  Misses        625      625           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added the pipelines This PR/issue is exclusively about improving our CI label Apr 21, 2023
@Oppen Oppen marked this pull request as ready for review April 21, 2023 18:40
@Oppen Oppen force-pushed the ci/hint_accountant branch from cb5bef7 to 09b890e Compare April 21, 2023 20:00
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oppen Oppen added this pull request to the merge queue Apr 21, 2023
Merged via the queue into main with commit 0155288 Apr 21, 2023
@Oppen Oppen deleted the ci/hint_accountant branch April 21, 2023 21:49
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants