-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: getters for prime, builtin names and data #1017
Merged
Merged
+94
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeaacb5
to
64cce08
Compare
juanbono
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pefontana
approved these changes
Apr 19, 2023
Benchmark Results for unmodified programs 🚀
|
11fe537
to
551de29
Compare
Required by starknet_in_rust, `Program` now has three new methods: - `prime() -> &str` returns the prime for that `Program` as a string - `iter_data() -> Iterator<Item = &MaybeRelocatable>`, an iterator over the program data - `iter_builtins() -> Iterator<Item = &BuiltinName>`, an iterator over the names of enabled builtins
551de29
to
38aca65
Compare
Codecov Report
@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 98.03% 98.04%
=======================================
Files 76 76
Lines 31767 31845 +78
=======================================
+ Hits 31143 31221 +78
Misses 624 624
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
Required by starknet_in_rust, `Program` now has three new methods: - `prime() -> &str` returns the prime for that `Program` as a string - `iter_data() -> Iterator<Item = &MaybeRelocatable>`, an iterator over the program data - `iter_builtins() -> Iterator<Item = &BuiltinName>`, an iterator over the names of enabled builtins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by starknet_in_rust,
Program
now has three new methods:prime() -> &str
returns the prime for thatProgram
as a stringiter_data() -> Iterator<Item = &MaybeRelocatable>
, an iterator over the program dataiter_builtins() -> Iterator<Item = &BuiltinName>
, an iterator over the names of enabled builtinsChecklist