-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : Fix CairoRunner::get_memory_holes
#1027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 20, 2023 20:14
Oppen
reviewed
Apr 20, 2023
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 78 78
Lines 32498 32541 +43
=======================================
+ Hits 31873 31916 +43
Misses 625 625
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Apr 21, 2023
MegaRedHand
approved these changes
Apr 21, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add test * Ignore builtin segments in get_memory_holes * Improve test * Add memory holes check for cairo_run_test tests * Fix broken condition * Make memory_holes check optional & customizable * Fix bounds * Add a test with deliberately created memory holes * Fix test value * Remove duplicated tests + add memory hole value to some tests * Add memory holes value + remove duplicated tests + fix typo * Fix test values * Add changelog entry * Link PR in Changelog * Mark breaking change in changelog * fmt * Fix test value * Fix codecov-patch diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the
get_memory_holes
method which was uncorreclty counting memory holes for builtin segments.In the python VM, all addresses in the builtin's segment are marked as accessed before counting memory holes. In this PR, builtin segments are skipped when counting memory holes instead.
Changes:
Skip builtin segements when counting memory holes
Check amount of memory holes for all tests in cairo_run_test
Remove duplicated tests in cairo_run_test
Checklist