Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hints): NewHint#67 cairo_keccak.json _block_permutation #1046

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Apr 24, 2023

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Oppen Oppen force-pushed the feat(hint)/67-cairo_keccak_block_permutation_v2 branch from 47436b4 to 24316ea Compare April 24, 2023 21:22
@Oppen Oppen changed the base branch from main to feat(hint)/66-cairo_keccak_finalize_v2 April 24, 2023 21:23
@Oppen Oppen force-pushed the feat(hint)/66-cairo_keccak_finalize_v2 branch from 816ae94 to 83e7f87 Compare April 24, 2023 21:24
@Oppen Oppen force-pushed the feat(hint)/67-cairo_keccak_block_permutation_v2 branch from 24316ea to d0e462e Compare April 24, 2023 21:24
Base automatically changed from feat(hint)/66-cairo_keccak_finalize_v2 to main April 24, 2023 22:25
@Oppen Oppen changed the title Feat(hint)/67 cairo keccak block permutation v2 Feat(hints): NewHint#67 cairo_keccak.json _block_permutation Apr 24, 2023
@Oppen Oppen changed the title Feat(hints): NewHint#67 cairo_keccak.json _block_permutation feat(hints): NewHint#67 cairo_keccak.json _block_permutation Apr 24, 2023
@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.521 ± 0.044 2.484 2.641 1.00 ± 0.02
head blake2s_integration_benchmark 2.512 ± 0.011 2.501 2.535 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.061 ± 0.044 3.021 3.154 1.00 ± 0.01
head compare_arrays_200000 3.056 ± 0.014 3.040 3.085 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.422 ± 0.042 2.397 2.540 1.00 ± 0.02
head dict_integration_benchmark 2.421 ± 0.018 2.403 2.463 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.732 ± 0.011 3.717 3.745 1.00 ± 0.01
head factorial_multirun 3.721 ± 0.024 3.705 3.788 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.009 ± 0.012 2.995 3.033 1.00
head fibonacci_1000_multirun 3.012 ± 0.031 2.977 3.078 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 128.9 ± 1.1 127.5 131.4 1.00
head field_arithmetic_get_square_benchmark 130.2 ± 3.0 128.5 138.6 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 2.970 ± 0.018 2.947 3.001 1.00
head integration_builtins 2.995 ± 0.057 2.952 3.151 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 2.700 ± 0.026 2.676 2.742 1.00 ± 0.01
head keccak_integration_benchmark 2.687 ± 0.020 2.668 2.727 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.167 ± 0.019 3.142 3.205 1.00
head linear_search 3.178 ± 0.021 3.159 3.229 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.696 ± 0.048 2.653 2.826 1.00 ± 0.02
head math_cmp_and_pow_integration_benchmark 2.686 ± 0.009 2.674 2.698 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.489 ± 0.009 2.476 2.509 1.00
head math_integration_benchmark 2.491 ± 0.012 2.474 2.513 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.132 ± 0.012 2.111 2.148 1.00
head memory_integration_benchmark 2.145 ± 0.017 2.129 2.177 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.216 ± 0.025 2.197 2.280 1.00
head operations_with_data_structures_benchmarks 2.222 ± 0.020 2.203 2.275 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 784.6 ± 8.9 777.7 806.1 1.00
head pedersen 784.6 ± 2.4 781.6 789.4 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.510 ± 0.015 1.496 1.551 1.00
head poseidon_integration_benchmark 1.516 ± 0.007 1.505 1.531 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.368 ± 0.007 2.358 2.377 1.00
head secp_integration_benchmark 2.392 ± 0.031 2.371 2.475 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.691 ± 0.014 1.678 1.727 1.00
head set_integration_benchmark 1.702 ± 0.010 1.689 1.727 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.932 ± 0.013 3.916 3.955 1.01 ± 0.00
head uint256_integration_benchmark 3.909 ± 0.007 3.895 3.919 1.00

@Oppen Oppen force-pushed the feat(hint)/67-cairo_keccak_block_permutation_v2 branch from 30e26be to ee3d3fc Compare April 25, 2023 15:14
@Oppen Oppen force-pushed the feat(hint)/67-cairo_keccak_block_permutation_v2 branch 3 times, most recently from 9f253d6 to 88e88d1 Compare April 25, 2023 20:01
@MegaRedHand MegaRedHand added the whitelisted-hint Implementation of hint on whitelist directory label Apr 25, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Oppen Oppen force-pushed the feat(hint)/67-cairo_keccak_block_permutation_v2 branch 2 times, most recently from 94feb05 to d45afcd Compare April 25, 2023 20:41
@Oppen Oppen force-pushed the feat(hint)/67-cairo_keccak_block_permutation_v2 branch from d45afcd to 1954317 Compare April 25, 2023 20:41
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1046 (960ef7c) into main (f92e167) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
- Coverage   98.09%   98.08%   -0.01%     
==========================================
  Files          84       84              
  Lines       33522    33552      +30     
==========================================
+ Hits        32882    32909      +27     
- Misses        640      643       +3     
Impacted Files Coverage Δ
...uiltin_hint_processor/cairo_keccak/keccak_hints.rs 93.84% <89.65%> (-0.52%) ⬇️
...int_processor/builtin_hint_processor_definition.rs 98.93% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
@Oppen Oppen enabled auto-merge April 26, 2023 02:40
@Oppen Oppen added this pull request to the merge queue Apr 26, 2023
@Oppen Oppen removed this pull request from the merge queue due to a manual request Apr 26, 2023
@Oppen Oppen added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit 1feaba0 Apr 26, 2023
@Oppen Oppen deleted the feat(hint)/67-cairo_keccak_block_permutation_v2 branch April 26, 2023 04:24
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
…aclass#1046)

* feat(hint): implement whitelisted hint lambdaclass#67

* Fix typo

* Fix CHANGELOG

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants