Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hints): NewHint#60 #1052

Merged
merged 31 commits into from
Apr 26, 2023
Merged

feat(hints): NewHint#60 #1052

merged 31 commits into from
Apr 26, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 25, 2023 •
edited
Loading

Depends on #1035

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.505 ± 0.032 2.465 2.560 1.01 ± 0.02
head blake2s_integration_benchmark 2.484 ± 0.022 2.448 2.522 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.047 ± 0.043 3.009 3.136 1.01 ± 0.02
head compare_arrays_200000 3.031 ± 0.036 2.986 3.120 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.391 ± 0.012 2.374 2.416 1.00
head dict_integration_benchmark 2.392 ± 0.009 2.382 2.410 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.714 ± 0.017 3.695 3.752 1.00
head factorial_multirun 3.729 ± 0.012 3.713 3.755 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 2.992 ± 0.017 2.971 3.028 1.00
head fibonacci_1000_multirun 3.005 ± 0.028 2.975 3.067 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 128.9 ± 2.8 127.0 136.5 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 127.2 ± 1.0 125.8 129.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 2.925 ± 0.014 2.909 2.954 1.00
head integration_builtins 2.935 ± 0.016 2.911 2.966 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 2.650 ± 0.009 2.632 2.665 1.00
head keccak_integration_benchmark 2.675 ± 0.048 2.642 2.799 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.136 ± 0.020 3.105 3.172 1.00
head linear_search 3.136 ± 0.042 3.109 3.252 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.677 ± 0.009 2.664 2.690 1.00
head math_cmp_and_pow_integration_benchmark 2.686 ± 0.045 2.650 2.799 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.467 ± 0.028 2.443 2.536 1.01 ± 0.01
head math_integration_benchmark 2.448 ± 0.012 2.431 2.471 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.126 ± 0.011 2.108 2.146 1.01 ± 0.01
head memory_integration_benchmark 2.112 ± 0.007 2.101 2.119 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.213 ± 0.020 2.190 2.266 1.01 ± 0.01
head operations_with_data_structures_benchmarks 2.194 ± 0.011 2.180 2.215 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 781.1 ± 2.4 777.8 786.0 1.00
head pedersen 783.6 ± 12.6 772.0 810.2 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.516 ± 0.014 1.506 1.553 1.00 ± 0.02
head poseidon_integration_benchmark 1.516 ± 0.018 1.503 1.566 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.360 ± 0.038 2.334 2.462 1.00 ± 0.02
head secp_integration_benchmark 2.359 ± 0.028 2.339 2.431 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.683 ± 0.025 1.671 1.753 1.00 ± 0.02
head set_integration_benchmark 1.676 ± 0.006 1.670 1.687 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.891 ± 0.037 3.855 3.961 1.01 ± 0.01
head uint256_integration_benchmark 3.867 ± 0.016 3.853 3.907 1.00

@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #1052 (714056f) into main (0f57c5d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1052   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          84       84           
  Lines       33826    33837   +11     
=======================================
+ Hits        33181    33192   +11     
  Misses        645      645
Impacted Files Coverage Δ
...rocessor/builtin_hint_processor/secp/secp_utils.rs 100.00% <ø> (ø)
...int_processor/builtin_hint_processor_definition.rs 98.99% <100.00%> (+0.01%) ⬆️
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.50% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta changed the base branch from main to hint-62 April 25, 2023 18:36
@fmoletta fmoletta changed the base branch from hint-62 to main April 25, 2023 18:36
@fmoletta fmoletta changed the base branch from main to hint-62 April 25, 2023 19:33
@fmoletta fmoletta marked this pull request as ready for review April 25, 2023 19:34
@fmoletta fmoletta requested a review from igaray as a code owner April 25, 2023 19:34
Base automatically changed from hint-62 to main April 25, 2023 20:27
@Oppen Oppen added the whitelisted-hint Implementation of hint on whitelist directory label Apr 25, 2023
juanbono
juanbono requested changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at the comment.

@fmoletta fmoletta requested a review from juanbono April 26, 2023 13:24
@Oppen Oppen added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit 327ee7d Apr 26, 2023
@Oppen Oppen deleted the new-hint-60 branch April 26, 2023 17:14
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
@fmoletta @pefontana
@Oppen @kariy
feat(hints): NewHint#60 (lambdaclass#1052)
9bcdf83 
* Add hint code

* Add cairo_programs/compute_slope_v2.cairo

* add hints code

* implement compute_slope_v2

* Implement VERIFY_ZERO_V3

* Add verify_zero_v3 unit tests

* Add COMPUTE_SLOPE_V2 unit test

* Update CHANGELOG.md

* cargo clippy

* Implement hint

* fmt

* Add changelog entry

* Add integration test

* cargo clippy

* Update cairo_run_test.rs

* Fix changelog

* Remove duplicated test

* fixes

* Fix fast_ec_add_assign_new_y

* Fix tests

* Clippy

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@Oppen Oppen Oppen approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

@Juan-M-V Juan-M-V Awaiting requested review from Juan-M-V

Assignees
No one assigned
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmoletta @Oppen @juanbono @pefontana