-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add ids.is_250
and ids.is_small
hint implementations
#1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 26, 2023 18:47
MegaRedHand
force-pushed
the
sirhint-is_250-and-is_small
branch
from
April 26, 2023 18:51
fdb1186
to
ec4970b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1073 +/- ##
========================================
Coverage 98.10% 98.10%
========================================
Files 84 84
Lines 33994 34135 +141
========================================
+ Hits 33349 33489 +140
- Misses 645 646 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
Apr 26, 2023
fmoletta
reviewed
Apr 27, 2023
fmoletta
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a small suggestion
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 27, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
…lambdaclass#1073) * Add starknet_in_rust IS_250_BITS hint * Add starknet_in_rust IS_ADDR_BOUNDED hint * Update changelog * Remove unnecessary `mod_floor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1059
Closes: #1060
Description
This PR moves the implementation of two hints over from the starknet_in_rust project. The two hints are now called:
IS_250_BITS
andIS_ADDR_BOUNDED
.Checklist