-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: eager resize for ´load_data´ #1117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
May 4, 2023 21:51
Oppen
force-pushed
the
perf/eager_memory_resize_load_data
branch
from
May 4, 2023 21:52
c86ce85
to
2b4eaf4
Compare
Oppen
force-pushed
the
perf/eager_memory_resize_load_data
branch
from
May 4, 2023 21:54
2b4eaf4
to
afef3b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1117 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 85 85
Lines 34546 34546
=======================================
Hits 33909 33909
Misses 637 637
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
fmoletta
approved these changes
May 5, 2023
juanbono
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the overhead during runner/vm initialization (relevant for sequencers that recycle a single program) comes from multiple resizes when calling
load_data
.Reversing the iterator ensures the resize happens only once, as the biggest offset will be inserted first.
According to criterion benchmarks, initialization takes 29.5% less time.
NOTE: there seems to be a minimal (<0.02+-0.02) performance hit on runtime, presumably due to zeroing out cells to later overwrite them. While more complex, an option would be to
.try_reserve
instead and then pushing in forward order. For now, I think the complexity/performance trade off balances quite highly in favor of not adding such code.Checklist