-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uint512DivMod Hint #1171
Add Uint512DivMod Hint #1171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding an integration test or at least creating an issue for it, otherwise lgtm
yes! I am working on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
As Fede mentioned, add an integration test and we are good to go
CHANGELOG.md
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
#### Upcoming Changes | |||
|
|||
* feat: Implement 'Uint512DivMod' hint [#1171](https://github.com/lambdaclass/cairo-rs/pull/1171) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a detail, the implementation of the cairo 1 hints are mentioned above in the changelog.
Just add the link to this PR in that line and remove this line
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.02%
==========================================
Files 89 89
Lines 35651 35725 +74
==========================================
+ Hits 34840 34908 +68
- Misses 811 817 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* Add Uint512DivMod Hint * Update changelog * Implement test for hint * Fix test for hint * Fix changelog * Fix changelog --------- Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
TITLE
Description
Description of the pull request changes and motivation.
Checklist