Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hint EC_DOUBLE_ASSIGN_NEW_X_V2 #1186

Merged
merged 3 commits into from
May 29, 2023
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented May 29, 2023

Now takes SECP_P from scope

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta marked this pull request as ready for review May 29, 2023 19:31
@fmoletta fmoletta linked an issue May 29, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1186 (5ba024f) into main (0a14a99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          89       89           
  Lines       35865    35936   +71     
=======================================
+ Hits        35042    35113   +71     
  Misses        823      823           
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 99.07% <100.00%> (+<0.01%) ⬆️
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.51% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 29, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.649 ± 0.114 11.517 11.866 1.00 ± 0.02
head blake2s_integration_benchmark 11.649 ± 0.156 11.479 11.931 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.831 ± 0.066 3.779 3.989 1.00 ± 0.02
head compare_arrays_200000 3.818 ± 0.053 3.778 3.956 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.596 ± 0.052 2.554 2.739 1.00 ± 0.02
head dict_integration_benchmark 2.584 ± 0.016 2.563 2.613 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.945 ± 0.028 3.913 3.992 1.00
head factorial_multirun 3.984 ± 0.035 3.946 4.066 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.429 ± 0.014 3.399 3.444 1.00
head fibonacci_1000_multirun 3.436 ± 0.055 3.398 3.589 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 176.0 ± 2.1 173.7 180.7 1.00
head field_arithmetic_get_square_benchmark 179.2 ± 9.4 174.0 204.0 1.02 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.715 ± 0.747 10.342 12.796 1.02 ± 0.07
head integration_builtins 10.495 ± 0.154 10.261 10.771 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 12.044 ± 0.389 11.699 12.777 1.03 ± 0.03
head keccak_integration_benchmark 11.716 ± 0.109 11.587 11.878 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.810 ± 0.014 3.795 3.830 1.00 ± 0.01
head linear_search 3.807 ± 0.022 3.779 3.839 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.721 ± 0.011 2.707 2.747 1.00
head math_cmp_and_pow_integration_benchmark 2.749 ± 0.039 2.712 2.806 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.572 ± 0.015 2.554 2.594 1.00 ± 0.01
head math_integration_benchmark 2.567 ± 0.011 2.551 2.588 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.165 ± 0.010 2.154 2.181 1.00
head memory_integration_benchmark 2.167 ± 0.010 2.153 2.186 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.553 ± 0.011 2.533 2.572 1.00
head operations_with_data_structures_benchmarks 2.564 ± 0.044 2.531 2.657 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 866.9 ± 3.4 861.9 872.2 1.00
head pedersen 868.3 ± 2.9 865.3 874.9 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.605 ± 0.008 1.597 1.625 1.00 ± 0.01
head poseidon_integration_benchmark 1.601 ± 0.005 1.597 1.614 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.073 ± 0.016 3.052 3.094 1.00
head secp_integration_benchmark 3.078 ± 0.038 3.048 3.166 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.751 ± 0.022 1.739 1.812 1.00 ± 0.02
head set_integration_benchmark 1.750 ± 0.024 1.733 1.815 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.584 ± 0.052 7.528 7.702 1.00
head uint256_integration_benchmark 7.593 ± 0.116 7.521 7.869 1.00 ± 0.02

@pefontana pefontana enabled auto-merge May 29, 2023 23:01
@pefontana pefontana added this pull request to the merge queue May 29, 2023
Merged via the queue into main with commit 16db8ee May 29, 2023
@pefontana pefontana deleted the fix-ec-double-assign-new-x-v2 branch May 29, 2023 23:47
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Fix hint `EC_DOUBLE_ASSIGN_NEW_X_V2`

* Add changelog entry

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hint EC_DOUBLE_ASSIGN_NEW_X_V2 should take SECP_P from scope
3 participants