Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of scientific notation with fractional values #1202

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jun 5, 2023

Closes #1199

@fmoletta fmoletta marked this pull request as ready for review June 5, 2023 20:05
Copy link
Collaborator

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 15.000 ± 0.350 14.696 15.861 1.02 ± 0.03
head blake2s_integration_benchmark 14.755 ± 0.218 14.457 15.114 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.862 ± 0.096 4.711 5.014 1.01 ± 0.02
head compare_arrays_200000 4.796 ± 0.056 4.675 4.859 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.156 ± 0.045 3.086 3.241 1.00 ± 0.02
head dict_integration_benchmark 3.143 ± 0.048 3.090 3.208 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.118 ± 0.069 5.023 5.253 1.00
head factorial_multirun 5.145 ± 0.062 5.040 5.238 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.421 ± 0.082 4.312 4.549 1.01 ± 0.02
head fibonacci_1000_multirun 4.363 ± 0.057 4.284 4.471 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 210.3 ± 21.7 187.4 264.3 1.09 ± 0.12
head field_arithmetic_get_square_benchmark 192.9 ± 6.5 181.5 200.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 13.671 ± 0.501 13.310 15.038 1.00
head integration_builtins 13.731 ± 0.337 13.261 14.234 1.00 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 15.247 ± 0.397 14.808 16.219 1.00
head keccak_integration_benchmark 15.291 ± 0.348 14.806 15.870 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.833 ± 0.098 4.698 4.977 1.00
head linear_search 4.837 ± 0.049 4.728 4.886 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.333 ± 0.057 3.265 3.446 1.00 ± 0.02
head math_cmp_and_pow_integration_benchmark 3.324 ± 0.043 3.257 3.386 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.123 ± 0.033 3.071 3.187 1.00 ± 0.01
head math_integration_benchmark 3.121 ± 0.031 3.093 3.190 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.702 ± 0.045 2.661 2.810 1.00
head memory_integration_benchmark 2.736 ± 0.063 2.669 2.905 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.034 ± 0.069 2.969 3.196 1.01 ± 0.03
head operations_with_data_structures_benchmarks 3.005 ± 0.045 2.937 3.107 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.032 ± 0.020 1.008 1.066 1.01 ± 0.03
head pedersen 1.022 ± 0.024 1.000 1.070 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.772 ± 0.012 1.754 1.793 1.00
head poseidon_integration_benchmark 1.804 ± 0.048 1.750 1.895 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.939 ± 0.047 3.872 4.040 1.00
head secp_integration_benchmark 3.980 ± 0.052 3.875 4.052 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.053 ± 0.043 1.982 2.124 1.00
head set_integration_benchmark 2.099 ± 0.053 2.021 2.186 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.813 ± 0.154 8.659 9.205 1.01 ± 0.02
head uint256_integration_benchmark 8.754 ± 0.106 8.651 8.975 1.00

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1202 (63db5fa) into main (de6a232) will decrease coverage by 0.02%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   97.60%   97.59%   -0.02%     
==========================================
  Files          89       89              
  Lines       36066    36089      +23     
==========================================
+ Hits        35202    35220      +18     
- Misses        864      869       +5     
Impacted Files Coverage Δ
src/serde/deserialize_program.rs 96.73% <82.75%> (-0.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana enabled auto-merge June 5, 2023 21:03
@pefontana pefontana disabled auto-merge June 5, 2023 21:03
@pefontana pefontana enabled auto-merge June 5, 2023 21:29
@pefontana pefontana added this pull request to the merge queue Jun 5, 2023
Merged via the queue into main with commit fc09e20 Jun 5, 2023
@pefontana pefontana deleted the fix-scientific-notation branch June 5, 2023 22:21
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
…mbdaclass#1202)

* First draft

* Simplify implementation

* Remove test

* Add changelog entry

* Clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cairo program de-serialization failure
3 participants