-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Uint256 unsigned div rem Hints #1203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefontana
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
Juan-M-V
as code owners
June 5, 2023 21:18
Oppen
approved these changes
Jun 5, 2023
fmoletta
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark Results for unmodified programs 🚀
|
juanbono
approved these changes
Jun 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 89 89
Lines 36089 36089
=======================================
Hits 35220 35220
Misses 869 869
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Fix bug * Fix U256 inserts * Add integration test * Remove dbg * Update CHANGELOG.md * Add UINT256_EXPANDED_UNSIGNED_DIV_REM test * Fix memeory holes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Uint256 unsigned div rem Hints
Checklist