-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reference management optimizations #1214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
June 10, 2023 05:15
Oppen
changed the title
perf: refence management optimizations
perf: reference management optimizations
Jun 10, 2023
MegaRedHand
approved these changes
Jun 12, 2023
pefontana
approved these changes
Jun 13, 2023
Benchmark Results for modified programs 🚀
|
- Store directly the reference list rather than the whole `ReferenceManager` structures - Only process them once, when creating the `Program` - Move them to the `SharedProgramData` member - Convert to `Vec<HintReference>` and adapt the methods using it
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
- Coverage 97.61% 97.57% -0.04%
==========================================
Files 88 88
Lines 36112 36110 -2
==========================================
- Hits 35251 35235 -16
- Misses 861 875 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* wip * test passing * more accurate bench * fix * perf: optimizations for reference management - Store directly the reference list rather than the whole `ReferenceManager` structures - Only process them once, when creating the `Program` - Move them to the `SharedProgramData` member - Convert to `Vec<HintReference>` and adapt the methods using it --------- Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program
creation rather than in each call torun_for_steps
Vec<_>
rather than aHashMap<_, _>
since the instance is denseSharedProgramData
structure instead of copying it each timeBenchmarks