Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensure_no_std build to CI #1232

Merged
merged 25 commits into from
Jun 16, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
0e2df78
Add ensure_no_std build to CI
MegaRedHand Jun 13, 2023
c10ecb0
Add print to test
MegaRedHand Jun 13, 2023
2d2ded8
Install wasm32 target for no-std testing
MegaRedHand Jun 13, 2023
67f1767
Fix: added option in wrong job
MegaRedHand Jun 13, 2023
88ca921
Try another breaking change
MegaRedHand Jun 13, 2023
eb9589b
Remove "alloc" feature in Cargo.toml
MegaRedHand Jun 13, 2023
60cd94d
Also add compilation with the 'alloc' option
MegaRedHand Jun 13, 2023
b935ddf
Add cairo-vm to ensure_no_std deps
MegaRedHand Jun 13, 2023
97ebba2
Remove alloc feature
MegaRedHand Jun 14, 2023
7ba3063
Fix (WIP)
MegaRedHand Jun 14, 2023
1f8939d
comment vm (not no_std ready); use nightly toolchain
Jun 15, 2023
7da2312
add Timothée num-prime fork and fix no-std support
Jun 15, 2023
0df698a
run cargo fmt
Jun 15, 2023
63fbd26
fix clippy; add original num_prime for tests; ignore unused FloatCore
Jun 15, 2023
763b766
fix typo on unused_variables instead imports
Jun 15, 2023
b18db22
remove prime computations for non default primality test config
Jun 15, 2023
6629e4f
Merge branch 'main' into add-ensure_no_std-to-CI
MegaRedHand Jun 15, 2023
d7a8262
Split implementation of is_prime into std/no_std
MegaRedHand Jun 15, 2023
3d627ec
Remove unused import
MegaRedHand Jun 15, 2023
bbcf0c4
Change some constants
MegaRedHand Jun 15, 2023
0f03d99
Update dir name
MegaRedHand Jun 15, 2023
b2148ba
Fix errors
MegaRedHand Jun 15, 2023
1451c77
Use modpow, and increase time of bench
MegaRedHand Jun 15, 2023
a732598
Merge smoke and smoke-no_std
MegaRedHand Jun 15, 2023
c08a4b8
Use mul instead of pow
MegaRedHand Jun 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
name: Run Lints
runs-on: ubuntu-22.04
steps:
- name: Install Rust 1.69.0
- name: Install Rust
uses: dtolnay/rust-toolchain@1.69.0
with:
components: rustfmt, clippy
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
name: Make sure all builds work
runs-on: ubuntu-22.04
steps:
- name: Install Rust 1.69.0
- name: Install Rust
uses: dtolnay/rust-toolchain@1.69.0
- name: Set up cargo cache
uses: Swatinem/rust-cache@v2
Expand Down Expand Up @@ -158,6 +158,27 @@ jobs:
run: cargo check-all-features --workspace --all-targets


# NOTE: the term "smoke test" comes from electronics design: the minimal
# expectations anyone has in their device is to not catch fire on boot.
smoke-no-std:
name: Make sure no-std works
runs-on: ubuntu-22.04
steps:
- name: Install Rust
uses: dtolnay/rust-toolchain@1.69.0
with:
targets: wasm32-unknown-unknown
- name: Set up cargo cache
uses: Swatinem/rust-cache@v2
- name: Checkout
uses: actions/checkout@v3

- name: Check
run: |
cd ensure_no_std
cargo build --release
cargo build --release -F alloc

MegaRedHand marked this conversation as resolved.
Show resolved Hide resolved
tests:
needs: build-programs
strategy:
Expand All @@ -168,7 +189,7 @@ jobs:
name: Run tests
runs-on: ubuntu-22.04
steps:
- name: Install Rust 1.69.0
- name: Install Rust
uses: dtolnay/rust-toolchain@1.69.0
with:
components: llvm-tools-preview
Expand Down Expand Up @@ -237,7 +258,7 @@ jobs:
name: Build release binary for comparisons
runs-on: ubuntu-22.04
steps:
- name: Install Rust 1.69.0
- name: Install Rust
uses: dtolnay/rust-toolchain@1.69.0
- name: Set up cargo cache
uses: Swatinem/rust-cache@v2
Expand Down
Loading