-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: explicitly set resolver version in virtual manifest #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
July 3, 2023 18:59
The default for crates with edition >= 2021 is the version 2 of the resolver. Virtual manifests, however, default to version 1. Seems that when we moved the VM to its own directory, we also changed the resolver we used.
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 89 89
Lines 35470 35470
=======================================
Hits 34721 34721
Misses 749 749 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
Jul 4, 2023
pefontana
approved these changes
Jul 4, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
…#1311) * Explicitly set resolver version in virtual manifest The default for crates with edition >= 2021 is the version 2 of the resolver. Virtual manifests, however, default to version 1. Seems that when we moved the VM to its own directory, we also changed the resolver we used. * Update changelog --------- Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
…#1311) * Explicitly set resolver version in virtual manifest The default for crates with edition >= 2021 is the version 2 of the resolver. Virtual manifests, however, default to version 1. Seems that when we moved the VM to its own directory, we also changed the resolver we used. * Update changelog --------- Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1260
Description
The default for crates with edition >= 2021 is version 2 of the resolver. Virtual manifests, however, default to version 1.
When we moved the VM to its own directory, we unknowingly changed the resolver we used.
Checklist