-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return error when hint's PC is invalid #1340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
July 19, 2023 14:08
Oppen
approved these changes
Jul 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1340 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 92 92
Lines 37684 37733 +49
=======================================
+ Hits 36745 36793 +48
- Misses 939 940 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pefontana
approved these changes
Jul 20, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Add test for failing program * Return error when some hint's PC isn't valid * Fix tests (+add test) * Appease clippy * Add some docs * Update changelog * Ignore manually compiled jsons in workflows cache * Fix warning in wasm-demo * Fix hash not hashing wasm-demo program * Fix mismatching paths
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Add test for failing program * Return error when some hint's PC isn't valid * Fix tests (+add test) * Appease clippy * Add some docs * Update changelog * Ignore manually compiled jsons in workflows cache * Fix warning in wasm-demo * Fix hash not hashing wasm-demo program * Fix mismatching paths
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1338
Description
This PR fixes the panic described in the issue by checking that a hint's PC is valid (lower than the
data
segment's length).Also, modifies the jsons cache so that manually compiled programs aren't cached, and unifies path arguments in them.
Checklist