Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cairo 2 compilation to makefile #1347

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

SantiagoPittella
Copy link
Contributor

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@SantiagoPittella SantiagoPittella added the pipelines This PR/issue is exclusively about improving our CI label Jul 26, 2023
@pefontana pefontana enabled auto-merge July 26, 2023 19:00
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1347 (374d800) into main (c73b728) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files          92       92           
  Lines       37718    37718           
=======================================
  Hits        36770    36770           
  Misses        948      948           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.262 ± 0.013 4.242 4.283 1.00 ± 0.01
head big_factorial 4.249 ± 0.021 4.225 4.297 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.662 ± 0.014 3.644 3.690 1.00 ± 0.01
head big_fibonacci 3.658 ± 0.019 3.630 3.690 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.940 ± 0.045 9.887 10.023 1.00 ± 0.01
head blake2s_integration_benchmark 9.919 ± 0.031 9.888 9.986 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.713 ± 0.017 3.681 3.740 1.00 ± 0.01
head compare_arrays_200000 3.709 ± 0.012 3.694 3.727 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.463 ± 0.009 2.454 2.482 1.00
head dict_integration_benchmark 2.472 ± 0.005 2.464 2.481 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.809 ± 0.006 1.802 1.824 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.808 ± 0.007 1.799 1.816 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.805 ± 0.052 9.761 9.935 1.00 ± 0.01
head integration_builtins 9.794 ± 0.046 9.758 9.906 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 10.085 ± 0.118 10.006 10.402 1.00
head keccak_integration_benchmark 10.098 ± 0.038 10.055 10.178 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.707 ± 0.021 3.684 3.754 1.00 ± 0.01
head linear_search 3.691 ± 0.007 3.678 3.699 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.726 ± 0.012 2.710 2.740 1.00
head math_cmp_and_pow_integration_benchmark 2.741 ± 0.010 2.730 2.767 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.453 ± 0.011 2.428 2.469 1.00 ± 0.01
head math_integration_benchmark 2.448 ± 0.005 2.438 2.455 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.138 ± 0.008 2.130 2.158 1.00 ± 0.01
head memory_integration_benchmark 2.133 ± 0.010 2.121 2.153 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.389 ± 0.010 2.374 2.409 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.386 ± 0.017 2.370 2.426 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 856.1 ± 1.0 854.5 858.1 1.00
head pedersen 857.8 ± 1.9 855.0 860.8 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.534 ± 0.008 1.524 1.550 1.00
head poseidon_integration_benchmark 1.537 ± 0.005 1.532 1.545 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.858 ± 0.010 2.848 2.876 1.00
head secp_integration_benchmark 2.859 ± 0.009 2.849 2.883 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.471 ± 0.006 1.462 1.484 1.02 ± 0.01
head set_integration_benchmark 1.445 ± 0.007 1.438 1.460 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.610 ± 0.051 6.582 6.746 1.00 ± 0.01
head uint256_integration_benchmark 6.594 ± 0.026 6.568 6.641 1.00

@pefontana pefontana added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 7a1cabb Jul 26, 2023
@pefontana pefontana deleted the add-cairo-2-compilation-to-make-test branch July 26, 2023 20:06
@pefontana pefontana linked an issue Aug 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix make test
5 participants