Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPLIT_FELT hint #1387

Merged
merged 9 commits into from
Aug 22, 2023
Merged

Fix SPLIT_FELT hint #1387

merged 9 commits into from
Aug 22, 2023

Conversation

fmoletta
Copy link
Contributor

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@fmoletta fmoletta linked an issue Aug 17, 2023 that may be closed by this pull request
@fmoletta fmoletta marked this pull request as ready for review August 17, 2023 22:06
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.689 ± 0.029 3.657 3.747 1.01 ± 0.01
head big_factorial 3.670 ± 0.021 3.648 3.710 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.211 ± 0.053 3.171 3.356 1.01 ± 0.02
head big_fibonacci 3.192 ± 0.039 3.162 3.297 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.113 ± 0.081 9.041 9.237 1.01 ± 0.01
head blake2s_integration_benchmark 9.065 ± 0.072 9.006 9.207 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.237 ± 0.029 3.209 3.314 1.01 ± 0.01
head compare_arrays_200000 3.199 ± 0.009 3.184 3.212 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.198 ± 0.006 2.189 2.207 1.01 ± 0.00
head dict_integration_benchmark 2.187 ± 0.005 2.180 2.194 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.678 ± 0.007 1.666 1.689 1.00
head field_arithmetic_get_square_benchmark 1.678 ± 0.009 1.671 1.703 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.106 ± 0.075 9.038 9.232 1.01 ± 0.01
head integration_builtins 9.051 ± 0.058 9.006 9.168 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.279 ± 0.106 9.188 9.475 1.01 ± 0.01
head keccak_integration_benchmark 9.152 ± 0.048 9.101 9.264 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.279 ± 0.012 3.267 3.298 1.01 ± 0.00
head linear_search 3.253 ± 0.009 3.243 3.271 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.339 ± 0.010 2.325 2.357 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 2.323 ± 0.020 2.304 2.372 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.140 ± 0.016 2.119 2.173 1.02 ± 0.01
head math_integration_benchmark 2.092 ± 0.009 2.079 2.111 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.884 ± 0.023 1.865 1.933 1.01 ± 0.01
head memory_integration_benchmark 1.863 ± 0.005 1.854 1.871 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.083 ± 0.009 2.071 2.101 1.00 ± 0.01
head operations_with_data_structures_benchmarks 2.077 ± 0.007 2.067 2.086 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 831.9 ± 11.2 826.1 863.7 1.01 ± 0.01
head pedersen 825.3 ± 2.2 823.2 830.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.520 ± 0.009 1.514 1.544 1.01 ± 0.01
head poseidon_integration_benchmark 1.510 ± 0.002 1.504 1.512 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.590 ± 0.006 2.581 2.598 1.01 ± 0.01
head secp_integration_benchmark 2.560 ± 0.012 2.541 2.583 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.268 ± 0.006 1.263 1.284 1.03 ± 0.01
head set_integration_benchmark 1.231 ± 0.007 1.227 1.252 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.966 ± 0.063 5.914 6.115 1.01 ± 0.01
head uint256_integration_benchmark 5.914 ± 0.042 5.865 5.994 1.00

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1387 (2aa405b) into main (f09766c) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 99.42%.

@@           Coverage Diff            @@
##             main    #1387    +/-   ##
========================================
  Coverage   97.49%   97.50%            
========================================
  Files          93       93            
  Lines       37913    38081   +168     
========================================
+ Hits        36962    37129   +167     
- Misses        951      952     +1     
Files Changed Coverage Δ
...int_processor/builtin_hint_processor/math_utils.rs 98.26% <99.42%> (+0.11%) ⬆️
...int_processor/builtin_hint_processor_definition.rs 99.09% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Aug 22, 2023
Merged via the queue into main with commit 132da2c Aug 22, 2023
@pefontana pefontana deleted the fix-split-felt-hint branch August 22, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different behaviour between vms
3 participants