-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix underflow bug #1430
Fix underflow bug #1430
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 93 93
Lines 38504 38544 +40
=======================================
+ Hits 37342 37382 +40
Misses 1162 1162
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @Juan-M-V !!!
Can we add an integration test with a cairo program?
Benchmark Results for modified programs 🚀
|
CHANGELOG.md
Outdated
@@ -2,6 +2,8 @@ | |||
|
|||
#### Upcoming Changes | |||
|
|||
* fix: Using UINT256_HINT no longer panics when b is greater than 2^256 [#1430]([htt](https://github.com/lambdaclass/cairo-vm/pull/1430) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix: Using UINT256_HINT no longer panics when b is greater than 2^256 [#1430]([htt](https://github.com/lambdaclass/cairo-vm/pull/1430) | |
* fix: Using UINT256_HINT no longer panics when b is greater than 2^256 [#1430](https://github.com/lambdaclass/cairo-vm/pull/1430) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved: 0cd3f14
I only added uint tests because normally the hint throws an error when b is too big. This happens on the python implementation. Now our VM throws an error instead of panicking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
TITLE
Description
Fixes #1426
Checklist