-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: use VirtualMachine::load_data at initialization #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
September 11, 2023 14:01
Oppen
force-pushed
the
perf/load_data_sets_cache_size
branch
from
September 11, 2023 14:02
00baaa8
to
9219369
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
- Coverage 97.12% 97.12% -0.01%
==========================================
Files 91 91
Lines 37246 37245 -1
==========================================
- Hits 36176 36175 -1
Misses 1070 1070 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
fmoletta
previously approved these changes
Oct 9, 2023
fmoletta
approved these changes
Jan 26, 2024
pefontana
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CairoRunner::initialize_state
was usingSegmentManager::load_data
to loadthe code rather than
VirtualMachine::load_data
. The latter contains an optimizationfor the instruction cache, where it gets resized when loading the segment
0
,saving us from many reallocations during the main loop.
Running transactions 68000-68500 with Pathfinder shows a 9% speed improvement.
Checklist