-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update serialize memory for bin format #1447
feat: update serialize memory for bin format #1447
Conversation
Hey, very nice PR! The code itself looks great, but I need to check the references first to understand it better just in case :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked, so I can confidently approve :)
Just check the little u64
stuff.
Okay swapped usize -> u64 and updated for WASM tests |
Codecov Report
@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 96.99% 96.99% -0.01%
==========================================
Files 93 93
Lines 38782 38773 -9
==========================================
- Hits 37618 37606 -12
- Misses 1164 1167 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CairoPieMemory Serialization #1446
Description
Serialization of the CairoPieMemory trace to be handled in the binary format as the python VM here:
Byte serialization defined here:
Implementation options available here:
Checklist