feat: add printing hints #1476
Merged
feat: add printing hints #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
Oppen
reviewed
Nov 12, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
==========================================
- Coverage 96.82% 96.81% -0.01%
==========================================
Files 95 96 +1
Lines 39451 39525 +74
==========================================
+ Hits 38199 38267 +68
- Misses 1252 1258 +6 ☔ View full report in Codecov by Sentry. |
pefontana
reviewed
Nov 16, 2023
There was a problem hiding this comment.
Nice one @greged93 !
I think we are having some errors with the no_Std compilation,
https://github.com/lambdaclass/cairo-vm/actions/runs/6895813983/job/18760636735?pr=1476
They should be easy to fix
|
Right, nostd can't use stdout. The features should be mutually exclusive. |
pefontana
approved these changes
Nov 23, 2023
Oppen
approved these changes
Nov 23, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Apr 5, 2024
* add print hints * test * remove u256 add felt * change log * fix based on comments * add std feature for print * Move Cairo Programs * Update Makefile * Use print tag in test * cargo fmt * Update Makefile * Update Makefile --------- Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging Hint
Description
The goal of this PR is to add debugging hints in the cairo vm behind a feature flag
print.Checklist