-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HintProcessor::execute_hint_extensive
+ refactor hint_ranges
#1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
[WIP] Add
[WIP] Add Nov 23, 2023
HintProcessor::execute_hint_extensive
+ use a HashMap with Relocatable index for hint rangesHintProcessor::execute_hint_extensive
+ refactor hint_ranges
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
- Coverage 96.82% 96.81% -0.01%
==========================================
Files 96 96
Lines 39567 39574 +7
==========================================
+ Hits 38311 38315 +4
- Misses 1256 1259 +3 ☔ View full report in Codecov by Sentry. |
Oppen
reviewed
Nov 23, 2023
This reverts commit fc76a36.
Benchmark Results for unmodified programs 🚀
|
Oppen
reviewed
Nov 23, 2023
fmoletta
changed the title
[WIP] Add
Add Nov 24, 2023
HintProcessor::execute_hint_extensive
+ refactor hint_ranges
HintProcessor::execute_hint_extensive
+ refactor hint_ranges
fmoletta
requested review from
igaray,
entropidelic,
juanbono and
pefontana
as code owners
November 24, 2023 21:49
Oppen
approved these changes
Nov 24, 2023
pefontana
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a solution to the hint-relates problems faced when running the starknet os:
The proposed solution for each problem is:
HintProcessor
api with anexecute_hint_extensive
method which can return a map of extra hints to be loaded after the hint is executed. This new method comes with a default implementation that just callsexecute_hint
so that this change may not affect current implementors of the traitTests added for this new behaviour in #1494