-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle pc
s outside of program segment in VmException
#1501
Merged
pefontana
merged 7 commits into
main
from
hadnle-non-program-segment-pc-in-vm-exception
Nov 30, 2023
Merged
Handle pc
s outside of program segment in VmException
#1501
pefontana
merged 7 commits into
main
from
hadnle-non-program-segment-pc-in-vm-exception
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono and
pefontana
as code owners
November 30, 2023 16:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 96 96
Lines 39684 39684
=======================================
Hits 38423 38423
Misses 1261 1261 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
Oppen
approved these changes
Nov 30, 2023
pefontana
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes how pc values are handled in VmException to show the full pc value instead of assuming index = 0.
Disables debug information for errors produced when the pc is not in the program segment to avoid incorrect information being displayed.