-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add args
flag to cairo1-run
#1551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
entropidelic,
juanbono and
pefontana
as code owners
January 9, 2024 20:51
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
- Coverage 97.22% 97.20% -0.02%
==========================================
Files 91 91
Lines 37048 37127 +79
==========================================
+ Hits 36020 36091 +71
- Misses 1028 1036 +8 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
Oppen
reviewed
Jan 10, 2024
Oppen
previously approved these changes
Jan 11, 2024
This was referenced Jan 12, 2024
juanbono
previously approved these changes
Jan 15, 2024
Oppen
dismissed stale reviews from juanbono and themself
January 15, 2024 18:59
The base branch was changed.
Oppen
previously approved these changes
Jan 15, 2024
Oppen
approved these changes
Jan 15, 2024
juanbono
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing arguments to cairo 1 programs
As there isn't a set convention for arguments passed to cairo_run (and the current design doesn't allow using starknet's convention for arrays) the following convention was taken:
Example: