Add air_private_input flag to cairo1-run
#1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono and
pefontana
as code owners
juanbono
previously approved these changes
Jan 15, 2024
pefontana
previously approved these changes
Jan 15, 2024
| ```bash | ||
| make run | ||
| ``` | ||
| ``` |
Makefile
Outdated
| @@ -287,8 +289,8 @@ compare_memory: $(CAIRO_RS_MEM) $(CAIRO_MEM) | |||
| compare_trace_memory_proof: $(COMPILED_PROOF_TESTS) $(CAIRO_RS_TRACE_PROOF) $(CAIRO_TRACE_PROOF) $(CAIRO_RS_MEM_PROOF) $(CAIRO_MEM_PROOF) | |||
| cd vm/src/tests; ./compare_vm_state.sh trace memory proof_mode | |||
|
|
|||
| compare_all_proof: $(COMPILED_PROOF_TESTS) $(CAIRO_RS_TRACE_PROOF) $(CAIRO_TRACE_PROOF) $(CAIRO_RS_MEM_PROOF) $(CAIRO_MEM_PROOF) $(CAIRO_RS_AIR_PUBLIC_INPUT) $(CAIRO_AIR_PUBLIC_INPUT) | |||
| cd vm/src/tests; ./compare_vm_state.sh trace memory proof_mode air_public_input | |||
| compare_all_proof: $(COMPILED_PROOF_TESTS) $(CAIRO_RS_TRACE_PROOF) $(CAIRO_TRACE_PROOF) $(CAIRO_RS_MEM_PROOF) $(CAIRO_MEM_PROOF) $(CAIRO_RS_AIR_PUBLIC_INPUT) $(CAIRO_AIR_PUBLIC_INPUT) $(CAIRO_RS_AIR_PRIVATE_INPUT) $(CAIRO_AIR_PRIVATE_INPUT) | |||
There was a problem hiding this comment.
It runs the standalone script, added the necessary flags & arguments, nice catch!
pefontana
requested changes
Jan 16, 2024
CHANGELOG.md
Outdated
| @@ -2,21 +2,35 @@ | |||
|
|
|||
| #### Upcoming Changes | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
jejeje i think you forgot the conflicts in the Changelog
juanbono
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (and includes changes from) #1552