-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add print_output
flag to cairo-1
crate
#1575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
approved these changes
Jan 22, 2024
juanbono
previously approved these changes
Jan 22, 2024
Oppen
previously approved these changes
Jan 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Jan 22, 2024
pefontana
previously approved these changes
Jan 23, 2024
edg-l
previously approved these changes
Jan 23, 2024
juanbono
previously approved these changes
Jan 23, 2024
pefontana
dismissed stale reviews from juanbono, edg-l, and themself
via
January 23, 2024 21:47
f1c6731
pefontana
approved these changes
Jan 23, 2024
juanbono
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When activating the
print_output
flag, the program output will be serialized and printed out by the CLI.This new serialization will recursively fetch arrays from memory and print them out instead of just showing the start and end addresses for the top-level array.
For this example program:
Current output (main branch), no flags:
New output,
print_output
flag:No output will be shown if
print_output
is not enabled (unless the program returns a panic result)The decision to lock the output behind a cli flag is both to match the standard behaviour we have in the cairo-vm-cli crate for cairo 0 execution and to avoid having to execute the argument serialization logic when outputs are not needed
Addresses #1564