Feature: deserialize AIR private input #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
|
On a related topic, I do think it would make sense to have Any thoughts? |
Oppen
approved these changes
Jan 22, 2024
odesenfans
force-pushed
the
msl/deserialize-private-input
branch
from
05288e0 to
680e633
Compare
|
Added a unit test and rebased. |
odesenfans
force-pushed
the
msl/deserialize-private-input
branch
from
680e633 to
9206a77
Compare
Oppen
previously approved these changes
Jan 31, 2024
fmoletta
previously approved these changes
Feb 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
=======================================
Coverage 97.66% 97.67%
=======================================
Files 91 91
Lines 37318 37393 +75
=======================================
+ Hits 36448 36523 +75
Misses 870 870 ☔ View full report in Codecov by Sentry. |
pefontana
previously approved these changes
Feb 2, 2024
|
@odesenfans Here too, just merge conflicts and we will merge it! |
odesenfans
dismissed stale reviews from pefontana, fmoletta, and Oppen
via
8d8d5d8
odesenfans
force-pushed
the
msl/deserialize-private-input
branch
2 times, most recently
from
8d8d5d8 to
ca261bc
Compare
pefontana
approved these changes
Feb 14, 2024
|
@odesenfans were you able to merge main? |
Added an implementation of `From<AirPrivateInputSerializable>` for AirPrivateInput.
odesenfans
force-pushed
the
msl/deserialize-private-input
branch
from
ca261bc to
5830048
Compare
|
Hey @pefontana , sorry I was busy with something else. I just rebased the branch. |
juanbono
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation of
From<AirPrivateInputSerializable>for AirPrivateInput, making it easier to interact with already generated private inputs.Checklist