Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Display for MemorySegmentManager #1606

Merged
merged 7 commits into from
Feb 21, 2024
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Feb 7, 2024

Adds a Display implementation to the MemorySegmentManager in order to improve the debugging(or other usage) experience from outside the crate in a similar fashion to the Display impl for Memory.
Displays the memory (using the Display impl for Memory) and the used size & size for each segment.

Also removes extra characters from Memory Display

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (beede16) 97.71% compared to head (82cd26d) 97.66%.

Files Patch % Lines
vm/src/vm/vm_memory/memory_segments.rs 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   97.71%   97.66%   -0.05%     
==========================================
  Files          91       91              
  Lines       37301    37318      +17     
==========================================
  Hits        36448    36448              
- Misses        853      870      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.304 ± 0.017 2.271 2.332 1.05 ± 0.02
head big_factorial 2.184 ± 0.032 2.143 2.237 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.290 ± 0.043 2.256 2.387 1.06 ± 0.02
head big_fibonacci 2.166 ± 0.018 2.144 2.192 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.599 ± 0.077 8.499 8.699 1.07 ± 0.01
head blake2s_integration_benchmark 8.067 ± 0.077 7.970 8.167 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.341 ± 0.016 2.325 2.384 1.03 ± 0.02
head compare_arrays_200000 2.266 ± 0.030 2.219 2.328 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.468 ± 0.008 1.452 1.479 1.03 ± 0.02
head dict_integration_benchmark 1.422 ± 0.022 1.405 1.481 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.407 ± 0.026 1.389 1.479 1.05 ± 0.02
head field_arithmetic_get_square_benchmark 1.345 ± 0.012 1.334 1.376 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.505 ± 0.076 8.429 8.642 1.06 ± 0.01
head integration_builtins 8.036 ± 0.036 7.983 8.107 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.769 ± 0.140 8.676 9.146 1.06 ± 0.02
head keccak_integration_benchmark 8.283 ± 0.087 8.195 8.413 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.349 ± 0.027 2.327 2.420 1.03 ± 0.02
head linear_search 2.276 ± 0.025 2.230 2.316 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.838 ± 0.029 1.812 1.916 1.02 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.797 ± 0.013 1.778 1.819 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.627 ± 0.022 1.606 1.686 1.03 ± 0.02
head math_integration_benchmark 1.578 ± 0.018 1.552 1.603 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.277 ± 0.006 1.264 1.284 1.01 ± 0.02
head memory_integration_benchmark 1.261 ± 0.027 1.239 1.322 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.904 ± 0.010 1.894 1.927 1.02 ± 0.01
head operations_with_data_structures_benchmarks 1.871 ± 0.013 1.862 1.904 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 593.2 ± 3.9 590.0 603.8 1.01 ± 0.01
head pedersen 584.8 ± 1.6 582.0 587.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.005 ± 0.031 0.990 1.093 1.02 ± 0.03
head poseidon_integration_benchmark 0.989 ± 0.014 0.972 1.017 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.936 ± 0.006 1.930 1.948 1.02 ± 0.01
head secp_integration_benchmark 1.899 ± 0.021 1.875 1.950 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 730.3 ± 2.1 726.5 734.4 1.01 ± 0.01
head set_integration_benchmark 723.7 ± 8.2 717.2 746.2 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.715 ± 0.121 4.638 5.042 1.06 ± 0.03
head uint256_integration_benchmark 4.461 ± 0.050 4.418 4.591 1.00

@fmoletta fmoletta marked this pull request as ready for review February 7, 2024 20:29
@pefontana pefontana enabled auto-merge February 21, 2024 16:34
@pefontana pefontana added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 0e6a235 Feb 21, 2024
50 of 51 checks passed
@pefontana pefontana deleted the mem-segments-display branch February 21, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants