Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only layout builtins in air private input #1651

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Mar 6, 2024

When converting to serializable format, the air private input contained all the builtins instead of only the ones present in the layout, this worked fine when running with starknet_with_keccak layout but produces a different output from cairo_lang when using a different layout that doesn't use all the builtins

@fmoletta fmoletta marked this pull request as ready for review March 6, 2024 18:39
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (7566aa5) to head (287f313).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          91       91           
  Lines       37668    37681   +13     
=======================================
+ Hits        36796    36809   +13     
  Misses        872      872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 6, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.268 ± 0.051 2.232 2.402 1.00
head big_factorial 2.287 ± 0.026 2.251 2.330 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.272 ± 0.026 2.251 2.340 1.01 ± 0.01
head big_fibonacci 2.240 ± 0.018 2.208 2.264 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.433 ± 0.354 8.244 9.348 1.00
head blake2s_integration_benchmark 8.666 ± 0.359 8.428 9.500 1.03 ± 0.06
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.330 ± 0.028 2.305 2.391 1.00
head compare_arrays_200000 2.382 ± 0.056 2.339 2.525 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.446 ± 0.017 1.429 1.484 1.00
head dict_integration_benchmark 1.460 ± 0.014 1.445 1.497 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.308 ± 0.018 1.292 1.354 1.00
head field_arithmetic_get_square_benchmark 1.310 ± 0.003 1.306 1.314 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.481 ± 0.121 8.303 8.644 1.00
head integration_builtins 8.543 ± 0.037 8.481 8.605 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.705 ± 0.116 8.556 8.838 1.00
head keccak_integration_benchmark 8.948 ± 0.364 8.683 9.851 1.03 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.335 ± 0.017 2.317 2.371 1.00
head linear_search 2.382 ± 0.020 2.367 2.427 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.601 ± 0.021 1.577 1.641 1.00
head math_cmp_and_pow_integration_benchmark 1.604 ± 0.010 1.593 1.627 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.442 ± 0.009 1.425 1.456 1.00
head math_integration_benchmark 1.444 ± 0.005 1.434 1.450 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.252 ± 0.011 1.243 1.270 1.00
head memory_integration_benchmark 1.273 ± 0.006 1.264 1.279 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.617 ± 0.005 1.608 1.626 1.00
head operations_with_data_structures_benchmarks 1.640 ± 0.025 1.621 1.691 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 595.2 ± 2.4 593.4 601.6 1.00
head pedersen 595.5 ± 2.3 590.2 598.4 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.002 ± 0.003 0.999 1.009 1.00
head poseidon_integration_benchmark 1.010 ± 0.020 0.999 1.066 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.890 ± 0.032 1.872 1.978 1.00
head secp_integration_benchmark 1.930 ± 0.060 1.876 2.080 1.02 ± 0.04
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 728.2 ± 6.4 721.0 740.4 1.00
head set_integration_benchmark 731.6 ± 12.1 723.2 764.8 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.611 ± 0.018 4.583 4.640 1.00
head uint256_integration_benchmark 4.691 ± 0.027 4.651 4.724 1.02 ± 0.01

Copy link
Collaborator

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@fmoletta fmoletta enabled auto-merge March 7, 2024 20:10
@fmoletta fmoletta added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 59a97c7 Mar 7, 2024
51 checks passed
@fmoletta fmoletta deleted the show-only-layout-builtins branch March 7, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants