Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CairoRunner::add_additional_hash_builtin & VirtualMachine::disable_trace #1658

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Mar 11, 2024

Removes methods that were needed to make cairo-rs-py compatible with cairo-lang and are no longer needed

@fmoletta fmoletta marked this pull request as ready for review March 11, 2024 18:31
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (1725f0c) to head (a974293).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
- Coverage   96.56%   96.56%   -0.01%     
==========================================
  Files          95       95              
  Lines       38422    38380      -42     
==========================================
- Hits        37103    37062      -41     
+ Misses       1319     1318       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 11, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.325 ± 0.045 2.295 2.448 1.00
head big_factorial 2.347 ± 0.012 2.328 2.362 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.357 ± 0.069 2.318 2.544 1.00
head big_fibonacci 2.360 ± 0.014 2.342 2.384 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.563 ± 0.180 8.368 8.839 1.00
head blake2s_integration_benchmark 8.631 ± 0.177 8.446 8.829 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.387 ± 0.017 2.363 2.429 1.00
head compare_arrays_200000 2.458 ± 0.027 2.417 2.494 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.494 ± 0.010 1.484 1.517 1.00
head dict_integration_benchmark 1.504 ± 0.007 1.495 1.515 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.333 ± 0.021 1.305 1.379 1.00 ± 0.02
head field_arithmetic_get_square_benchmark 1.327 ± 0.011 1.316 1.350 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.519 ± 0.143 8.382 8.709 1.00
head integration_builtins 8.625 ± 0.140 8.432 8.778 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.783 ± 0.149 8.663 9.051 1.00
head keccak_integration_benchmark 8.844 ± 0.142 8.701 9.033 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.400 ± 0.010 2.387 2.423 1.00
head linear_search 2.497 ± 0.054 2.450 2.591 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.612 ± 0.013 1.600 1.633 1.00
head math_cmp_and_pow_integration_benchmark 1.656 ± 0.008 1.642 1.665 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.457 ± 0.013 1.443 1.480 1.00
head math_integration_benchmark 1.491 ± 0.008 1.478 1.502 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.306 ± 0.043 1.278 1.424 1.00
head memory_integration_benchmark 1.338 ± 0.009 1.324 1.349 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.642 ± 0.010 1.633 1.669 1.00
head operations_with_data_structures_benchmarks 1.675 ± 0.012 1.664 1.702 1.02 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 596.8 ± 2.0 594.0 601.2 1.00
head pedersen 609.8 ± 9.3 603.2 632.2 1.02 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 990.4 ± 7.1 981.1 999.4 1.00
head poseidon_integration_benchmark 1001.9 ± 11.5 994.8 1033.6 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.898 ± 0.023 1.880 1.942 1.00
head secp_integration_benchmark 1.904 ± 0.012 1.892 1.923 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 733.6 ± 7.7 728.3 748.2 1.00
head set_integration_benchmark 744.7 ± 5.2 738.2 757.8 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.768 ± 0.159 4.647 5.124 1.00
head uint256_integration_benchmark 4.783 ± 0.046 4.717 4.848 1.00 ± 0.03

@fmoletta fmoletta enabled auto-merge April 3, 2024 21:31
@fmoletta fmoletta added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 22a97dc Apr 3, 2024
52 checks passed
@fmoletta fmoletta deleted the clean-legacy-code branch April 3, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants