-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use return type info from sierra when serializing return values in cairo1-run crate #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
==========================================
- Coverage 96.70% 96.64% -0.07%
==========================================
Files 95 95
Lines 38154 38375 +221
==========================================
+ Hits 36897 37087 +190
- Misses 1257 1288 +31 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
fmoletta
changed the title
[Cairo1] Use return type info from sierra when serializing return values
Use return type info from sierra when serializing return values n cairo1-run crate
Mar 15, 2024
fmoletta
changed the title
Use return type info from sierra when serializing return values n cairo1-run crate
Use return type info from sierra when serializing return values in cairo1-run crate
Mar 15, 2024
fmoletta
requested review from
entropidelic,
juanbono and
pefontana
as code owners
March 15, 2024 14:06
juanbono
approved these changes
Mar 18, 2024
pefontana
approved these changes
Mar 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1664
Uses sierra program data to serialize each return value according to its concrete type.
Removes the public
serialize_output
function in favor of an internalserialize_output
function used bycairo_run_program
.Possible follow up work: See if we can find the names of the enum variants & struct fields in the sierra program data and include them in the serialization.