-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set dynamic params as null by default on air public input #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
requested review from
igaray,
Oppen,
juanbono and
pefontana
as code owners
April 16, 2024 15:11
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
=======================================
Coverage 94.80% 94.81%
=======================================
Files 100 100
Lines 38214 38207 -7
=======================================
- Hits 36228 36225 -3
+ Misses 1986 1982 -4 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
juanbono
approved these changes
Apr 16, 2024
|
pefontana
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1649
dynamic_params are always set to null on the cairo_lang implementation, even if these were to be added in the future, the structure of these params is different to that of
CairoLayout
, so it doesn't make much sense to keep serializing this struct.This PR removes the
CairoLayout
type from the dynamic_params field ofAirPublicInput
, replacing it with a()
type that serializes as null.This also removes the lifetime from
dynamic_params
, allowing us to use a representation that is not tied to a lifetime in thelayout
field (Such as the enum added by #1715)