-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TestLessThanOrEqualAddress y EvalCircuit Hints #1843
Open
FrancoGiachetta
wants to merge
25
commits into
main
Choose a base branch
from
new-hints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Results for unmodified programs 🚀
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
========================================
Coverage 96.32% 96.33%
========================================
Files 102 102
Lines 40381 40618 +237
========================================
+ Hits 38899 39129 +230
- Misses 1482 1489 +7 ☔ View full report in Codecov by Sentry. |
…o-vm into new-hints Support for Circuits builtins
FrancoGiachetta
changed the title
Implement TestLessThanOrEqual y EvalCircuit Hints
Implement TestLessThanOrEqualAddress y EvalCircuit Hints
Sep 30, 2024
FrancoGiachetta
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
October 1, 2024 12:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement TestLessThanOrEqual y EvalCircuit Hints
Description
This PR adds the implementations for
EvalCircuit
andTestLessThanOrEqual
. It also changes a little the bytecode that is executed. Before, the it final bytecode consisted of the entry_code, the casm instructions and the footer. Now, due to the way the hint is implemented, the segment values are appended after the casm instructions and before the footer. This is because these are values the operands that will be used to evaluate the circuit's operations, which referenced by the cells in the data segment.Relates to #1836
Checklist