-
Notifications
You must be signed in to change notification settings - Fork 199
Support wasm with cairo1 #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support wasm with cairo1 #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Results for unmodified programs 🚀
|
74c759b
to
709abe8
Compare
03f6ebe
to
563201a
Compare
563201a
to
597ebac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 104 104
Lines 44027 44027
=======================================
Hits 42566 42566
Misses 1461 1461 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fc2da60
to
64604a6
Compare
d7daaad
to
0d40642
Compare
DiegoCivi
reviewed
Oct 3, 2025
DiegoCivi
approved these changes
Oct 3, 2025
gabrielbosio
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support wasm with cairo1
Description
This PR makes some changes so that a cairo 1 program can be run with wasm:
cairo1-run
depends on cairo-vm with thestd
feature set. Since wasm does not support std features, this PR creates anstd
feature forcairo1-run
, which was set as a default feature to maintain compatibility. When used with wasm, default-features are set tofalse
.std
implementations forHashMap
andPeekable
with theirno_std
ones.std
feature.cairo1-run/src/cairo-run.rs
to beu64
instead ofusize
. This was needed by wasm to be able to compile properly.Checklist