Skip to content

Refactor Memory::relocate_memory #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Feb 2, 2023
Merged

Refactor Memory::relocate_memory #784

merged 28 commits into from
Feb 2, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Jan 26, 2023 •
edited
Loading

  • Refactor method
  • Add more test cases
  • Add more cairo programs to check relocation of temporary memory (these programs dont contain assertions, they are meant to be used by the memory comparison script)

@fmoletta fmoletta changed the title Refactor Memory::relocate memory Refactor Memory::relocate memory Jan 26, 2023
@fmoletta fmoletta marked this pull request as ready for review January 27, 2023 15:54
Oppen
Oppen approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some minor comments.

@fmoletta fmoletta changed the title Refactor Memory::relocate memory Refactor Memory::relocate_memory Jan 27, 2023
fmoletta and others added 2 commits January 27, 2023 15:24
@fmoletta @Oppen
Update CHANGELOG.md
72cecd8 
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
@fmoletta
Merge branch 'main' into refactor-relocate-memory
d317f20
Jrigada
Jrigada approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor typos!

fmoletta and others added 4 commits February 2, 2023 06:50
@fmoletta @Jrigada
Update src/vm/vm_memory/memory.rs
37fd791 
Co-authored-by: Juan Rigada <62958725+Jrigada@users.noreply.github.com>
@fmoletta @Jrigada
Update src/vm/vm_memory/memory.rs
f18f31b 
Co-authored-by: Juan Rigada <62958725+Jrigada@users.noreply.github.com>
@fmoletta
Merge branch 'main' of github.com:lambdaclass/cairo-rs into refactor-…
dfd4c29 
…relocate-memory
@fmoletta
Merge branch 'refactor-relocate-memory' of github.com:lambdaclass/cai…
510c59c 
…ro-rs into refactor-relocate-memory
Oppen
Oppen approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

@fmoletta fmoletta merged commit 4a642c7 into main Feb 2, 2023
@fmoletta fmoletta deleted the refactor-relocate-memory branch February 2, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oppen Oppen Oppen approved these changes

@igaray igaray Awaiting requested review from igaray

@entropidelic entropidelic Awaiting requested review from entropidelic

@HermanObst HermanObst Awaiting requested review from HermanObst

@juanbono juanbono Awaiting requested review from juanbono

@pefontana pefontana Awaiting requested review from pefontana

@Juan-M-V Juan-M-V Awaiting requested review from Juan-M-V

+1 more reviewer

@Jrigada Jrigada Jrigada approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmoletta @Oppen @Jrigada