Refactor Memory::relocate_memory
#784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fmoletta
commented
Jan 26, 2023
•
fmoletta
commented
- Refactor method
- Add more test cases
- Add more cairo programs to check relocation of temporary memory (these programs dont contain assertions, they are meant to be used by the memory comparison script)
fmoletta
changed the title
Memory::relocate memory
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
HermanObst,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
Oppen
approved these changes
Jan 27, 2023
fmoletta
changed the title
Memory::relocate memoryMemory::relocate_memory
Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Co-authored-by: Juan Rigada <62958725+Jrigada@users.noreply.github.com>
Co-authored-by: Juan Rigada <62958725+Jrigada@users.noreply.github.com>
…ro-rs into refactor-relocate-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.