Check error types in vm_core.rs + simplify code #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
HermanObst,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 97.10% 97.13% +0.03%
==========================================
Files 69 69
Lines 28672 28652 -20
==========================================
- Hits 27842 27832 -10
+ Misses 830 820 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Feb 14, 2023
Juan-M-V
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_zerofunction -> its supposed to check if the offset is >= 0 in the case of relocatables, which is an impossible case. The fn no longer returns a resultAddAssignforRelocatable