-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MathError
for math operations
#855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able values (#853) * Print relocatables & missing members in write_output * Add test
Codecov Report
@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 96.84% 96.89% +0.05%
==========================================
Files 69 69
Lines 28807 28801 -6
==========================================
+ Hits 27897 27906 +9
+ Misses 910 895 -15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
HermanObst and
juanbono
as code owners
February 23, 2023 15:18
fmoletta
requested review from
Jrigada,
pefontana and
Juan-M-V
as code owners
February 23, 2023 15:18
Jrigada
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how you organized this change, looks great.
* Catch possible overflows in Relocatable::add * Move sub implementations to trait impl * Swap sub_usize for - operator * Vheck possible overflows in Add<i32> * Fix should_panic test * remove referenced add * Replace Relocatable methods for trait implementations * Catch overflows in mayberelocatable operations * Fix keccak * Clippy
Oppen
approved these changes
Mar 2, 2023
Oppen
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to collect math-related errors scattered around
VirtualMachineError
&RunnerError
into its own Error.Errors related to: type conversions, functions on math.rs, relocatable & mayberelocatable operations have been moved to MathError