Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Relocatable instead of &MaybeRelocatable in load_data #860

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

fmoletta
Copy link
Contributor

Change the ptr argument type in MemorySegmentManager::load_data to Relocatable

@fmoletta fmoletta changed the title Use Relocatable instead of &MaybeRelocatable in load_data Use Relocatable instead of &MaybeRelocatable in load_data Feb 24, 2023
@fmoletta fmoletta marked this pull request as ready for review February 24, 2023 18:13
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #860 (5c421ab) into main (e0da0be) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   96.86%   96.85%   -0.01%     
==========================================
  Files          69       69              
  Lines       28966    28948      -18     
==========================================
- Hits        28057    28039      -18     
  Misses        909      909              
Impacted Files Coverage Δ
..._processor/builtin_hint_processor/blake2s_utils.rs 99.48% <100.00%> (-0.02%) ⬇️
src/vm/runners/cairo_runner.rs 97.53% <100.00%> (-0.01%) ⬇️
src/vm/vm_core.rs 97.52% <100.00%> (ø)
src/vm/vm_memory/memory_segments.rs 99.02% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it!

@Oppen Oppen added this pull request to the merge queue Mar 1, 2023
Merged via the queue into main with commit c15c642 Mar 1, 2023
@Oppen Oppen deleted the load-data-relocatable branch March 1, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants