Remove builtin names from VirtualMachine.builtin_runners
#921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motive: Simplify code & have a cleaner/simpler interface
Reasoning: builtin runners are now enums instead of trait objectst, so we can know exectly which builtin we are using without needing to see its name. Morover, builtins know their name, we can just call builtin.name() if we need it.
Possible consecuences: The method
add_additional_hash_builtin
used to store the new builtin under a different name ("hash_builtin" instead of "pedersen"), but this wont longer be needed after 0.11 changesOther improvements: Simplified code catching NoBuiltinForLayout error
Performance: No difference