-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add alternative hint code for hint on _block_permutation
used by 0.10.3 whitelist
#958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
Add alternative string for hint on
Add alternative string for hint on Apr 11, 2023
_block_permutation
used by 10.3 whitelist_block_permutation
used by 0.10.3 whitelist
fmoletta
changed the title
Add alternative string for hint on
Add alternative hint code for hint on Apr 11, 2023
_block_permutation
used by 0.10.3 whitelist_block_permutation
used by 0.10.3 whitelist
fmoletta
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 11, 2023
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 11, 2023 15:51
Codecov Report
@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 75 75
Lines 30970 30970
=======================================
Hits 30274 30274
Misses 696 696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Apr 13, 2023
Oppen
reviewed
Apr 13, 2023
src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs
Show resolved
Hide resolved
fmoletta
changed the title
Add alternative hint code for hint on
feat: Add alternative hint code for hint on Apr 13, 2023
_block_permutation
used by 0.10.3 whitelist_block_permutation
used by 0.10.3 whitelist
Oppen
approved these changes
Apr 13, 2023
pefontana
approved these changes
Apr 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Apr 14, 2023
Oppen
reviewed
Apr 14, 2023
…-rs into block_permutation_hint
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 14, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
… by 0.10.3 whitelist (lambdaclass#958) * Add alternative hint string * Fix whitelist name * Add integration test * Add changelog entry * Remove old file * Fix broken tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method _block_permutation (in common/cairo_keccak/keccak) has the following string:
While the 0.10.3.json whitelist contains the same hint with the first line changed to:
from starkware.cairo.common.cairo_keccak.keccak_utils import keccak_func
Both hints behave the same, as
common/cairo_keccak/keccak_utils
just imports everything fromcommon/keccak_utils/keccak_utils
So now both code strings lead to the same hint function