-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update make deps #963
Update make deps #963
Conversation
Codecov Report
@@ Coverage Diff @@
## main #963 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 75 75
Lines 31155 31155
=======================================
Hits 30459 30459
Misses 696 696 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Small comment, but the README in the Getting Started section has pyenv in the Optional section, saying "These dependencies are only necessary in order to run the original VM and compile Cairo programs.". It should clarify that pyenv is required to run the tests. Another nitpick is if some downloads the repo and runs |
Thanks for the comment @igaray I update the README.md so users know that they need pyenv to run the test. Maybe instead it will be better to add the What do you think? |
dba7f1a
to
7ba4c72
Compare
* Add make deps-macos && update make deps * Add .python-version to .gitignore * pin bitarray version * Add pypy to deps * Modify python versions in un_benchmarks.sh * Update run_benchmarks.sh layouts * Add virtual envs to make deps * Update README.md * add make cargo-deps --------- Co-authored-by: Pedro Fontana <pedro.fontana@lamdaclass.com> Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Update make deps
Description
make deps
:3.9.15
andpypy3.9-7.3.9
bitarray==2.7.3
vesioncargo install --version 0.11.0 wasm-pack
make deps-macos
Description of the pull request changes and motivation.
Checklist