-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement hint on uint384_extension lib #983
Conversation
Codecov Report
@@ Coverage Diff @@
## main #983 +/- ##
========================================
Coverage 98.01% 98.02%
========================================
Files 75 76 +1
Lines 31297 31606 +309
========================================
+ Hits 30677 30981 +304
- Misses 620 625 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment.
Benchmark Results for unmodified programs 🚀
|
There seems to be a significant, reproducible (I retried the workflow twice) slowdown in several benchmarks. I think we should figure out what causes it before merging. EDIT: seems OK now. |
* Add hint code for UINT348_UNSIGNED_DIV_REM * Add file for uint348 files * Add pack & split for uint348 * Move comment * Implement uint348_unsigned_div_rem hint * Add integration test * Add integration test * Add unit tests * Add hint on split_128 * Test split_128 hint * Add add_no_uint384_hint * Fix hint + add tests * Add hint code for UINT348_UNSIGNED_DIV_REM_EXPAND * Msc fixes * Add integration test * Reduce Uint384_expand representation to the 3 used limbs * Add unit test * Add hint code for UINT384_SQRT * Add implementation for hint on sqrt * Integration test * Add unit tests * Fix missing directive * Run cairo-format * Add changelog entry * Spelling * Add hint code + Uint768 type * Implement hint unsigned_div_rem_uint768_by_uint384 * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Update src/hint_processor/builtin_hint_processor/uint384.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Make hint code more readable * Add integration test * Add test * Add unit test * Add changelog entry + fmt * Fix plural * cargo fmt * Fix test * Fix syntax * Fix test * Add necessary lib fns * fix fmt * Fix test value * Fix merge conflict * Fix merge conflict * Add misc tests * Remove vec use * Remove merge conflict from changelog * Catch potential zero divison errors --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Depends on #960
Implements the following hint:
Checklist