Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewHint#31 #991

Merged
merged 11 commits into from
Apr 17, 2023
Merged

Add NewHint#31 #991

merged 11 commits into from
Apr 17, 2023

Conversation

mfachal
Copy link
Contributor

@mfachal mfachal commented Apr 14, 2023

TITLE

Description

This PR adds the PACK_MODN_DIV_MODN and XS_SAFE_DIV hints

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #991 (8ffdc04) into main (c319786) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          75       75           
  Lines       31154    31196   +42     
=======================================
+ Hits        30458    30500   +42     
  Misses        696      696           
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.75% <100.00%> (+<0.01%) ⬆️
...processor/builtin_hint_processor/secp/signature.rs 98.83% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Oppen Oppen enabled auto-merge April 17, 2023 17:15
@Oppen Oppen added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit 263712a Apr 17, 2023
@Oppen Oppen deleted the newhint31-div-mod-n branch April 17, 2023 18:10
@pefontana pefontana added the whitelisted-hint Implementation of hint on whitelist directory label Apr 17, 2023
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* add program with div_mod_n

* make mul_s_inv program execute

* make mul_s_inv program execute

* add pack_modn_div_modn and mul_s_inv test

* add changes to changelog

* fix changelog merge

* fix changelog

* fix changelog style

---------

Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants