-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#25 and NewHint#24 #994
Conversation
34db699
to
7553821
Compare
3dcbf0f
to
7de765d
Compare
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 75 75
Lines 31260 31297 +37
=======================================
+ Hits 30640 30677 +37
Misses 620 620
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @MegaRedHand !!!
Just check that little detail
1854c68
to
67477d9
Compare
7de765d
to
7207002
Compare
Benchmark Results for unmodified programs 🚀
|
* Add NewHint#26 * Update changelog * Change assert_matches for assert + is_ok * Get and insert SECP_P from scope where applicable * Add NewHint#25 * Add NewHint#24 * Update changelog * Appease clippy * Rename hint codes * Get or insert N from scope * Change test contract * Fix test * Fix test (for real this time)
Description
Depends: #992
This PR adds the missing hints NewHint#25 and NewHint#24, now known as
DIV_MOD_N_SAFE_DIV_PLUS_ONE
andDIV_MOD_N_PACKED_DIVMOD_V2
respectively. It also renamesDIV_MOD_N_PACKED_DIVMOD
toDIV_MOD_N_PACKED_DIVMOD_V1
.